[wanda] Add contextOwner type and parser#479
Merged
andrew-anyscale merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
Contributor
Author
Contributor
Author
This was referenced Apr 2, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a contextOwner struct and a parseContextOwner function to parse "uid:gid" strings, along with corresponding unit tests. The review feedback suggests adding validation to ensure that UIDs and GIDs are non-negative and expanding the test suite to cover additional edge cases such as negative numbers, multiple colons, and leading spaces.
3a039ba to
36e12bb
Compare
Add the contextOwner struct and parseContextOwner function for parsing "uid:gid" strings. This will be used to allow wanda specs to override file ownership in the build context tar. Topic: add-context-owner Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com>
36e12bb to
433015c
Compare
aslonnie
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the contextOwner struct and parseContextOwner function for parsing "uid:gid" strings. This will be used to allow wanda specs to override file ownership in the build context tar.
Topic: add-context-owner
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Signed-off-by: andrew andrew@anyscale.com