Skip to content

[wanda] Add contextOwner type and parser#479

Merged
andrew-anyscale merged 1 commit intomainfrom
andrew/revup/main/add-context-owner
Apr 6, 2026
Merged

[wanda] Add contextOwner type and parser#479
andrew-anyscale merged 1 commit intomainfrom
andrew/revup/main/add-context-owner

Conversation

@andrew-anyscale
Copy link
Copy Markdown
Contributor

@andrew-anyscale andrew-anyscale commented Apr 2, 2026

Add the contextOwner struct and parseContextOwner function for parsing "uid:gid" strings. This will be used to allow wanda specs to override file ownership in the build context tar.

Topic: add-context-owner

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Signed-off-by: andrew andrew@anyscale.com

@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

Reviews in this chain:
#479 [wanda] Add contextOwner type and parser
 └#480 [wanda] Wire context owner override through tar writing
  └#481 [wanda] Add context_owner spec option and include in cache digest

@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

andrew-anyscale commented Apr 2, 2026

# head base diff date summary
0 3a039ba0 c6680a89 diff Apr 2 13:44 PM 2 files changed, 58 insertions(+)
1 36e12bbe c6680a89 diff Apr 2 13:55 PM 2 files changed, 14 insertions(+), 1 deletion(-)
2 433015c0 ee2e3961 diff Apr 2 19:35 PM 0 files changed

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a contextOwner struct and a parseContextOwner function to parse "uid:gid" strings, along with corresponding unit tests. The review feedback suggests adding validation to ensure that UIDs and GIDs are non-negative and expanding the test suite to cover additional edge cases such as negative numbers, multiple colons, and leading spaces.

Comment thread wanda/tar_meta.go
Comment thread wanda/tar_meta_test.go Outdated
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/main/add-context-owner branch from 3a039ba to 36e12bb Compare April 2, 2026 20:55
Add the contextOwner struct and parseContextOwner function for parsing "uid:gid" strings. This will be used to allow wanda specs to override file ownership in the build context tar.

Topic: add-context-owner

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/main/add-context-owner branch from 36e12bb to 433015c Compare April 3, 2026 02:35
@andrew-anyscale andrew-anyscale marked this pull request as ready for review April 3, 2026 02:35
@andrew-anyscale andrew-anyscale requested a review from aslonnie April 3, 2026 02:35
@andrew-anyscale andrew-anyscale merged commit 1a7ef66 into main Apr 6, 2026
2 checks passed
@andrew-anyscale andrew-anyscale deleted the andrew/revup/main/add-context-owner branch April 6, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants