[wanda] Wire context owner override through tar writing#480
[wanda] Wire context owner override through tar writing#480andrew-anyscale merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to override UID and GID for all entries in a tar stream by adding an owner field to the tarStream struct and propagating it to the tarFile.writeTo method. While the implementation correctly updates the tar headers, the reviewer pointed out that the owner field is currently missing from the digest() calculation. This omission could lead to cache collisions where different ownership settings result in the same digest. It is recommended to include the owner information in the digest and add a test case to verify that digest values change when ownership is modified.
fac3b48 to
91254ad
Compare
3a039ba to
36e12bb
Compare
Add the contextOwner struct and parseContextOwner function for parsing "uid:gid" strings. This will be used to allow wanda specs to override file ownership in the build context tar. Topic: add-context-owner Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com>
Add an owner field to tarStream that, when set, overrides the uid/gid on all file entries written to the tar. Pass the owner through tarFile.writeTo so each file header gets the override applied. Topic: add-context-owner-tar Relative: add-context-owner Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com>
36e12bb to
433015c
Compare
91254ad to
08d056c
Compare
|
Add an owner field to tarStream that, when set, overrides the uid/gid on all file entries written to the tar. Pass the owner through tarFile.writeTo so each file header gets the override applied.
Topic: add-context-owner-tar
Relative: add-context-owner
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Signed-off-by: andrew andrew@anyscale.com