[code-quality] Improve InlineArrayReturnAssignRector to include implicit array instantiation and nested arrays

[TomasVotruba]

No description provided.

[samsonasik]

It looks similar to InlineArrayReturnAssignRector

rector-src/rules/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector.php

Line 29 in 77b0f25

final class InlineArrayReturnAssignRector extends AbstractRector

see https://getrector.com/rule-detail/inline-array-return-assign-rector

[TomasVotruba]

Thanks 👍 I could not find this one. I'll extend it

[samsonasik]

when param named $person sshould be skipped

[TomasVotruba]

Indeed 👍 Could you handle it? I'm off soon

[samsonasik]

I will check if any regression if conflict with existing params

[samsonasik]

see PR:

• [CodeQuality] Skip append from params on InlineArrayReturnAssignRector #7273

[samsonasik]

There are many regression on this, eg: this should be skipped

     public function some(SomeObject $someObject): array
     {
-        $message = [
-           'type' => 'type'
-            'id' => (string) $someObject->getId(),
-        ];
-        $message['link'] = $this->getSome($someObject);

 -      return $message;
+        return ['link' => $this->getSome($fuelOrder)];
     }

Also, if there is an if before:

         $someVar[$variable] = (float) $data;
 
         if (rand(0, 1)) {
-            $someVar[sprintf('%', $type)] = 0.0;
-            $someVar[$type] = 0.0;
-
-            return $someVar;
+            return ['' => 0.0];
         }

also cause crash on UnaryMinus:

         "System error: "Not implemented yet. Go to "Rector\PhpParser\Node\NodeFactory::createArrayItem()" and add check
         for "PhpParser\Node\Expr\UnaryMinus" node."  

I will look into those :)

[samsonasik]

The reason for complex append is invalid is because we don't know the variable is available before first variable as this PR cause not rely on initialization, that cause this invalid change:

         $someVar[$variable] = (float) $data;
 
         if (rand(0, 1)) {
-            $someVar[sprintf('%', $type)] = 0.0;
-            $someVar[$type] = 0.0;
-
-            return $someVar;
+            return ['' => 0.0];
         }

[samsonasik]

PR for skip init before if

• [CodeQuality] Skip init is before if on InlineArrayReturnAssignRector #7274

[samsonasik]

This dynamic key should also be skipped:

     public function create($variable, $type, $data)
     {
-        $someVar[sprintf('%', $type)] = 0.0;
-        $someVar[$type] = 0.0;
-
-        return $someVar;
+        return ['' => 0.0];

[samsonasik]

PR for dynamic key skip:

• [CodeQuality] Skip dynamic key on InlineArrayReturnAssignRector #7275

[samsonasik]

PR for skip init non empty array:

• [CodeQuality] Skip init not empty array on InlineArrayReturnAssignRector #7276

[samsonasik]

PR for handle crash on unary plus/minus:

• [CodeQuality] Handle crash on UnaryMinus/UnaryPlus on InlineArrayReturnAssignRector #7277

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.