add support for boolean vs constant boolean type in UseIdenticalOverEqualWithSameTypeRector

[TomasVotruba]

No description provided.

[samsonasik]

this cause regression on numeric string "1", see https://3v4l.org/JEeP5

I will create PR to skip numeric string.

[samsonasik]

I created PR:

• [CodeQuality] Skip equal to identical on numeric string and boolean on UseIdenticalOverEqualWithSameTypeRector #7410

to skip compare to numeric string.

[samsonasik]

I found another regression that it cause invalid result on integer 0 vs false, see https://3v4l.org/Pp8Vr

[samsonasik]

I created PR:

• [CodeQuality] Skip bool equal integer on UseIdenticalOverEqualWithSameTypeRector #7411

to skip compare to integer.

[samsonasik]

I found another regression that it cause invalid result on float vs bool, see https://3v4l.org/I3GQS

[samsonasik]

I created PR:

• [CodeQuality] Skip bool equal float on UseIdenticalOverEqualWithSameTypeRector #7412

to skip compare to float.

[samsonasik]

I found a better approach by using TypeComparator so the type are both normalized on equal check.

• [CodeQuality] Use TypeComparator to verify Boolean vs Constant Boolean on UseIdenticalOverEqualWithSameTypeRector #7414

[TomasVotruba]

👍

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.