Skip to content

[CodeQuality] Skip equal to identical on numeric string and boolean on UseIdenticalOverEqualWithSameTypeRector#7410

Merged
samsonasik merged 7 commits intomainfrom
skip-equal-numeric
Oct 3, 2025
Merged

[CodeQuality] Skip equal to identical on numeric string and boolean on UseIdenticalOverEqualWithSameTypeRector#7410
samsonasik merged 7 commits intomainfrom
skip-equal-numeric

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Oct 3, 2025

Ref #7408 (review)

Fix the regression, see https://3v4l.org/9XRF6

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Member Author

@TomasVotruba I tested this on our project :)

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik changed the title [CodeQuality] Skip equal to identical on numeric string on UseIdenticalOverEqualWithSameTypeRector [CodeQuality] Skip equal to identical on numeric string and boolean on UseIdenticalOverEqualWithSameTypeRector Oct 3, 2025
@samsonasik samsonasik merged commit fb4abd2 into main Oct 3, 2025
55 of 56 checks passed
@samsonasik samsonasik deleted the skip-equal-numeric branch October 3, 2025 23:45
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant