Skip to content

fix(rivetkit-swift): avoid double percent-encoding paths in URLUtils #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Makisuo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(rivetkit-swift): avoid double percent-encoding paths in URLUtils #4609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f6ec8b
fix(rivetkit-swift): avoid double percent-encoding paths in URLUtils
Makisuo Apr 12, 2026
82064c7
shorten URLUtils percent-encoding comment
Makisuo Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rivetkit-swift/Sources/RivetKitClient/URLUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ enum URLUtils {
}

var components = URLComponents(url: baseUrl, resolvingAgainstBaseURL: false)
components?.path = fullPath
// fullPath is already percent-encoded (see buildActorGatewayUrl); .path would
// re-encode `%` and break actor IDs containing `:` (e.g. Cloudflare Workers).
components?.percentEncodedPath = fullPath
components?.percentEncodedQuery = queryParts.isEmpty ? nil : queryParts.joined(separator: "&")
components?.fragment = nil

Expand Down