Bump minimum jruby-openssl to 0.15.4 for CVE-2025-46551#1022
Open
Bump minimum jruby-openssl to 0.15.4 for CVE-2025-46551#1022
Conversation
jruby-openssl versions prior to 0.15.4 have hostname verification disabled by default, allowing man-in-the-middle attacks with valid certificates for different domains (GHSA-72qj-48g4-5xgx). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the JRuby-specific dependency constraint in openssl.gemspec to ensure JRuby users pick up a jruby-openssl version that includes the fix for CVE-2025-46551 (GHSA-72qj-48g4-5xgx).
Changes:
- Bump
jruby-opensslruntime dependency from~> 0.14to the0.15series. - Enforce a minimum
jruby-opensslversion of0.15.4on the Java/JRuby platform path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rhenium
reviewed
Mar 31, 2026
| spec.platform = "java" | ||
| spec.files = [] | ||
| spec.add_runtime_dependency('jruby-openssl', '~> 0.14') | ||
| spec.add_runtime_dependency('jruby-openssl', '~> 0.15', '>= 0.15.4') |
Member
There was a problem hiding this comment.
Suggested change
| spec.add_runtime_dependency('jruby-openssl', '~> 0.15', '>= 0.15.4') | |
| spec.add_runtime_dependency('jruby-openssl') |
0.15.4 satisfies ~> 0.14, so it appears to be a false positive caused by Dependabot's loose pattern matching.
I wonder if we can avoid it and similar issues in the future by simply dropping the version constraint, since it doesn't seem to be useful anyway.
Member
Author
There was a problem hiding this comment.
I agreed to remove version constraint too.
@headius Do you have any opinion about that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recieved the dependabot alert for
GHSA-72qj-48g4-5xgxat ruby/ruby repository. We should bump up tojruby-openssldependency with fixed version./cc @headius