Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openssl.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
if Gem::Platform === spec.platform and spec.platform =~ 'java' or RUBY_ENGINE == 'jruby'
spec.platform = "java"
spec.files = []
spec.add_runtime_dependency('jruby-openssl', '~> 0.14')
spec.add_runtime_dependency('jruby-openssl', '~> 0.15', '>= 0.15.4')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
spec.add_runtime_dependency('jruby-openssl', '~> 0.15', '>= 0.15.4')
spec.add_runtime_dependency('jruby-openssl')

0.15.4 satisfies ~> 0.14, so it appears to be a false positive caused by Dependabot's loose pattern matching.

I wonder if we can avoid it and similar issues in the future by simply dropping the version constraint, since it doesn't seem to be useful anyway.

Copy link
Copy Markdown
Member Author

@hsbt hsbt Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agreed to remove version constraint too.

@headius Do you have any opinion about that?

else
spec.files = Dir.glob(["lib/**/*.rb", "ext/**/*.{c,h,rb}", "*.md"], base: File.expand_path("..", __FILE__)) +
["BSDL", "COPYING"]
Expand Down
Loading