Skip to content

Fix cyclic dependency in frontend #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kobzol merged 1 commit into from
Dec 20, 2025
+6 −8
Merged

Fix cyclic dependency in frontend #2357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/frontend/src/pages/compare/prefs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {createStoredValue} from "../../storage";
import {DATE_FMT_24HR} from "../../utils/formatting";
import {DATE_FMT_24HR} from "../../utils/date-formats";

export const PREF_FILTERS_OPENED = createStoredValue(
"compare.filters-opened",
Expand Down
2 changes: 1 addition & 1 deletion site/frontend/src/pages/status/date-format-selection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup lang="ts">
import {DATE_FMT_12HR} from "../../utils/formatting";
import {DATE_FMT_12HR} from "../../utils/date-formats";

const props = defineProps<{
dateFmt: string;
Expand Down
3 changes: 1 addition & 2 deletions site/frontend/src/pages/status/page.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import {
formatISODate,
formatSecondsAsDuration,
parseDateIsoStringOrNull,
DATE_FMT_12HR,
DATE_FMT_24HR,
preferredDateTimeFormat,
} from "../../utils/formatting";
import {useExpandedStore} from "../../utils/expansion";
Expand All @@ -24,6 +22,7 @@ import {
import Collector from "./collector.vue";
import CommitSha from "./commit-sha.vue";
import DateFmtPicker from "./date-format-selection.vue";
import {DATE_FMT_12HR, DATE_FMT_24HR} from "../../utils/date-formats";

const loading = ref(true);

Expand Down
3 changes: 3 additions & 0 deletions site/frontend/src/utils/date-formats.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// Date formats taken from https://date-fns.org/v4.1.0/docs/format
export const DATE_FMT_24HR = "yyyy-MM-dd HH:mm:ss";
export const DATE_FMT_12HR = "yyyy-MM-dd hh:mm:ss a";
4 changes: 0 additions & 4 deletions site/frontend/src/utils/formatting.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ export function formatSecondsAsDuration(time: number): string {
return s;
}

// Date formats taken from https://date-fns.org/v4.1.0/docs/format
export const DATE_FMT_24HR = "yyyy-MM-dd HH:mm:ss";
export const DATE_FMT_12HR = "yyyy-MM-dd hh:mm:ss a";

export const preferredDateTimeFormat = createPersistedRef(PREF_DATETIME_FORMAT);

// Takes a date like `2025-09-10T08:22:47.161348Z` and formats it according to
Expand Down
Loading