Skip OpenAI model registration when no API key is configured#1446
Open
antisilent wants to merge 4 commits into
Open
Skip OpenAI model registration when no API key is configured#1446antisilent wants to merge 4 commits into
antisilent wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1445.
Summary
register_modelsandregister_embedding_modelsin the built-in OpenAI plugin now return early if no API key is found (viallm keys,keys.json, orOPENAI_API_KEY). If credentials are not configured, the plugin is invisible.env_setup) now sets a dummyOPENAI_API_KEYso existing tests continue to work, and scrubsLLM_MODEL,LLM_EMBEDDING_MODEL, andLLM_EMBEDDINGS_DBto prevent host environment variables from leaking into tests.test_openai_models_not_registered_without_keyto cover the new behavior.Test plan
uv run pytestpasses (755 tests)llm modelsshows no OpenAI models whenOPENAI_API_KEYis unset and no key is storedllm modelsshows OpenAI models normally once a key is configured