Open
Conversation
…nt values, incremented currentSettingDataVersion (now 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[!] This PR is dependent on #1097
Description
Change the FOV slider to use the existing fov option system instead of modifying the base FOV value in
gameRenderer.Expands the slider range from 70-110 to 30-110, and makes slider values 1:1 with ticks.
Changes
Previous Behavior
The FOV slider values are not accurate compared to other platforms and causes issues when high FOV values are used.
Root Cause
Current implementation uses the
gameRendererfunctionSetFovVal(), which changes the base FOV value used to render the game.The slider was implemented by creating a slider with a range of 0-100, then mapping that range to 70-110. This means the slider must be moved multiple ticks to change the value by 1.
New Behavior
Switched to using the method
Minecraft::GetInstance()->options->fovto adjust FOV.Slider values are now 1:1 with ticks.
Fix Implementation
Change
CMinecraftApp::ActionGameSettings()and slider implementations to use the methodMinecraft::GetInstance()->options->fovto adjust FOV.Change slider range to 0-80 instead of 0-100, change
eGameSetting_FOVto store FOV as a value 0-80 corresponding to the range 30-110 instead of a value 0-100Use
SettingFixer()(from #1097) to seamlessly convert old saved settings to new format.AI Use Disclosure
No AI was used to author these changes or pull request.
Related Issues