Conversation
tt-cll
commented
Mar 24, 2026
| hexStr = SVMFamilySelector | ||
| case chain_selectors.FamilyAptos: | ||
| hexStr = AptosFamilySelector | ||
| hexStr = "ac77ffec" |
Collaborator
Author
There was a problem hiding this comment.
only keeping these for backwards compat while the usages are migrated
|
tt-cll
requested review from
0xAustinWang,
KodeyThomas,
asoliman92,
chris-de-leon-cll,
Copilot,
matYang,
mateusz-sekara and
winder
Contributor
There was a problem hiding this comment.
Pull request overview
This PR shifts “common” chain-specific defaults (notably FeeQuoter dest-chain config and chain-family selector bytes4) out of shared lane utilities and into per-chain adapters, so ConnectChains callers/tests no longer need to manually populate those fields.
Changes:
- Remove caller-provided
FeeQuoterDestChainConfigfrom integration tests; rely on adapters to supply expected defaults. - Introduce an optional
ChainMetadataProvideradapter interface and a global chain-family-selector registry used byutils.GetSelectorHex. - Inline per-family selector constants into EVM/Solana adapters (and a few test helpers) and delete the prior shared defaults from
lanes.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| integration-tests/deployment/set_token_transfer_fee_test.go | Stops setting FeeQuoterDestChainConfig in ChainDefinition; relies on adapter defaults. |
| integration-tests/deployment/connect_chains_test.go | Updates assertions to source expected FeeQuoter config from the appropriate adapter rather than from the chain definition. |
| deployment/v1_7_0/changesets/configure_committee_verifiers_test.go | Updates mock adapter to provide an explicit FeeQuoter dest-chain config struct. |
| deployment/utils/common.go | Adds a global registry for family selectors and changes GetSelectorHex resolution behavior. |
| deployment/lanes/product.go | Adds ChainMetadataProvider and registers chain-family selectors during lane-adapter registration. |
| deployment/lanes/lane_update.go | Removes shared default builders (DefaultFeeQuoterDestChainConfig, DefaultGasPrice). |
| chains/solana/deployment/v1_6_0/sequences/adapter.go | Inlines SVM selector bytes4 and implements GetChainFamilySelector. |
| chains/evm/deployment/v1_6_0/sequences/adapter.go | Inlines EVM selector bytes4 and implements GetChainFamilySelector. |
| ccv/chains/evm/deployment/v1_7_0/testsetup/testsetup.go | Inlines EVM selector bytes4 for tests to avoid an import cycle. |
| ccv/chains/evm/deployment/v1_7_0/adapters/chain_family.go | Implements GetChainFamilySelector and inlines FeeQuoter dest-chain defaults for the adapter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
archseer
approved these changes
Mar 24, 2026
chris-de-leon-cll
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.