Fix proto generation for new subdirectories#248
Merged
Conversation
The `mv -f` command cannot merge directories — it fails when the destination directory already exists. Replace with `cp -rf` so that new proto subdirectories (e.g. nexusservices) are handled correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a3d5abf to
abff50d
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
carlydf
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace
mv -fwithcp -rfwhen flattening generated proto output, so new subdirectories (e.g.nexusservices) don't cause the build to fail.Why
mvcannot merge directories — when a new proto subdirectory is added to the api repo,mvfails with "cannot overwrite: Directory not empty". This is what's breaking the Update Proto workflow.Example error:
How did you test it?
Triggered a test run and it succeeded.
https://github.com/temporalio/api-go/actions/runs/24223347639
🤖 Generated with Claude Code