Skip to content

Fix proto generation for new subdirectories #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkannan82 merged 2 commits into from
Apr 10, 2026
+2 −1
Merged

Fix proto generation for new subdirectories #248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abff50d
Fix proto generation failing when new subdirectories are added
rkannan82 Apr 10, 2026
b2228a2
Add comment explaining cp vs mv choice
rkannan82 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ go-grpc: clean .go-helpers-installed $(PROTO_OUT)
-p grpc-gateway_out=allow_patch_feature=false,$(PROTO_PATHS) \
-p go-helpers_out=$(PROTO_PATHS)

mv -f $(PROTO_OUT)/temporal/api/* $(PROTO_OUT) && rm -rf $(PROTO_OUT)/temporal
# cp is safer than mv because mv cannot merge into existing directories
cp -rf $(PROTO_OUT)/temporal/api/* $(PROTO_OUT) && rm -rf $(PROTO_OUT)/temporal

http-api-docs: go-grpc
go run cmd/encode-openapi-spec/main.go \
Expand Down
Loading