Skip to content

fix(cli): scope CI env var to child process in Windows install script#1292

Open
fengmk2 wants to merge 1 commit intomainfrom
win-install-issue1288
Open

fix(cli): scope CI env var to child process in Windows install script#1292
fengmk2 wants to merge 1 commit intomainfrom
win-install-issue1288

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Apr 4, 2026

Use cmd /c "set CI=true && ..." instead of setting $env:CI directly,
so the variable is scoped to the child process and does not persist in the
user's PowerShell session. This prevented vp create from entering
interactive mode when run in the same terminal after installation.

Closes #1288

Use `cmd /c "set CI=true && ..."` instead of setting `$env:CI` directly,
so the variable is scoped to the child process and does not persist in the
user's PowerShell session. This prevented `vp create` from entering
interactive mode when run in the same terminal after installation.

Closes #1288
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 4, 2026

Deploy Preview for viteplus-preview ready!

Name Link
🔨 Latest commit 1709b3c
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69d074acf6e5cfa9a41fe824
😎 Deploy Preview https://deploy-preview-1292--viteplus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fengmk2 fengmk2 self-assigned this Apr 4, 2026
Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 4, 2026


How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 marked this pull request as ready for review April 4, 2026 02:16
Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 4, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 4, 2026

test worksimage.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vp create with no arguments should imply --interactive

1 participant