Skip to content

fix(cli): scope CI env var to child process in Windows install script #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fengmk2 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

fix(cli): scope CI env var to child process in Windows install script #1292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/cli/install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,8 +374,9 @@ function Main {
$installLog = Join-Path $VersionDir "install.log"
Push-Location $VersionDir
try {
$env:CI = "true"
& "$BinDir\vp.exe" install --silent *> $installLog
# Use cmd /c so CI=true is scoped to the child process only,
# avoiding leaking it into the user's shell session.
cmd /c "set CI=true && `"$BinDir\vp.exe`" install --silent" *> $installLog
if ($LASTEXITCODE -ne 0) {
Write-Host "error: Failed to install dependencies. See log for details: $installLog" -ForegroundColor Red
exit 1
Expand Down
Loading