fix: remove redundant tool filtering/prefix logic and fix prefix bug in VeIdentityMcpToolset#532
Open
MengJiapeng wants to merge 1 commit intovolcengine:mainfrom
Conversation
- Remove duplicate _is_tool_selected method, use parent class implementation - Remove redundant _tool_filter and _tool_name_prefix storage - Fix parent class initialization to pass tool_filter and tool_name_prefix - Remove buggy custom prefix logic that modified _name instead of name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #531
Summary
This PR fixes redundant code and a critical bug in
VeIdentityMcpToolsetwhere the tool name prefix feature was not working correctly.Changes
Bug Fixes
_nameattribute instead ofname, causing the prefix feature to completely fail. Now properly delegates to parent class'sget_tools_with_prefix()method.Code Cleanup
_is_tool_selected()method - now uses parent classBaseToolsetimplementation_tool_filterand_tool_name_prefixattribute storage - now properly passed to and stored by parent classtool_filterandtool_name_prefixparametersTest Updates
tool_filter,tool_name_prefixinstead of_tool_filter,_tool_name_prefix)test_get_tools_with_list_filter- verifies list-based tool filteringtest_get_tools_with_predicate_filter- verifies predicate-based tool filteringtest_get_tools_with_prefix_applies_correctly- verifies prefix is correctly added viaget_tools_with_prefix()test_get_tools_with_prefix_and_filter_combined- verifies prefix and filter work togetherTesting
All 15 tests pass: