[WIP] Datafusion 52 upgrade #5863
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
force-pushed
the
adamg/df-52-wip
branch
2 times, most recently
from
72a86ec to
605888e
Compare
Merging this PR will improve performance by 26.35%Summary
Performance Changes
Comparing 
|
41 tasks
AdamGS
force-pushed
the
adamg/df-52-wip
branch
from
e8517de to
cd278dc
Compare
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
AdamGS
force-pushed
the
adamg/df-52-wip
branch
4 times, most recently
from
94a43db to
3384dca
Compare
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
AdamGS
force-pushed
the
adamg/df-52-wip
branch
from
5677283 to
963682b
Compare
AdamGS
force-pushed
the
adamg/df-52-wip
branch
4 times, most recently
from
8ab2741 to
3a5af7a
Compare
AdamGS
force-pushed
the
adamg/df-52-wip
branch
3 times, most recently
from
2b46a55 to
933fcfc
Compare
AdamGS
force-pushed
the
adamg/df-52-wip
branch
8 times, most recently
from
ca2adc8 to
d877c4e
Compare
AdamGS
commented
Jan 8, 2026
| )) | ||
| } | ||
|
|
||
| fn split_projection( |
Contributor
Author
There was a problem hiding this comment.
I'm really unsure if this function should be part of the trait or just some internal implementation detail. I'm tempted to keep it out of the public API for now and see if anyone ever runs into needed to customize it.
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/df-52-wip
branch
from
d877c4e to
fb3fb1e
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the current tip of Datafusion to test the upcoming upgrade. It drops the use of the
SchemaAdapterAPI, removes the vendored code we pulled to fix some bugs and currently passes all of our tests!This PR requires at least one more round of polish, I'm sure I left some convoluted things in
opener.rs.Waiting for the upstream release:
52.0.0(Dec 2025 / Jan 2026) apache/datafusion#18566