do not enable OSC 7 support for old 5.x powershell

[sawka]

fix for #2471

[coderabbitai]

Walkthrough

Adds an early exit to the PowerShell Wave integration script to skip OSC 7 setup when the detected PowerShell version is less than 7; the check is placed after Wave completions are loaded and before first-prompt logic. Separately, in conncontroller.InstallWsh the error returned when client platform detection fails is wrapped using %w to preserve the original error for unwrapping.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–15 minutes

• Inspect pkg/util/shellutil/shellintegration/pwsh_wavepwsh.sh for correct PowerShell version detection and that the early exit location does not disrupt completions or prompt initialization.
• Review pkg/remote/conncontroller/conncontroller.go change to ensure error wrapping with %w is appropriate and preserves original error semantics.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check	❓ Inconclusive	The pull request description "fix for #2471" is extremely vague and generic, providing no meaningful information about what the changeset actually does or what problem it solves. While the reference to an issue number indicates this is related to a fix, the description itself is too minimal to verify that it actually describes the contents of the changeset without examining the linked issue. The description lacks any substantive detail about the changes made to either the PowerShell integration file or the error handling code.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "do not enable OSC 7 support for old 5.x powershell" is directly related to the primary change in the pull request, which adds an early exit in the PowerShell integration script when the version is less than 7 to skip OSC 7 setup. The title is specific, clear, and accurately reflects the main objective of the changeset. While there are secondary changes to error wrapping in conncontroller.go, the PowerShell OSC 7 change appears to be the primary focus based on the branch name and the more substantial modification.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch sawka/remove-osc7-in-old-powershell

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21faa99 and 5a68dfe.

📒 Files selected for processing (1)

• pkg/remote/conncontroller/conncontroller.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build for TestDriver.ai
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (go)

🔇 Additional comments (1)

pkg/remote/conncontroller/conncontroller.go (1)

490-490: Good use of error wrapping.

Using %w instead of %v properly preserves the error chain for unwrapping, which improves debuggability and follows Go 1.13+ best practices.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: unknown linters: 'unusedfunc,unusedparams', run 'golangci-lint help linters' to see the list of supported linters
The command is terminated due to an error: unknown linters: 'unusedfunc,unusedparams', run 'golangci-lint help linters' to see the list of supported linters

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}