Skip to content

do not enable OSC 7 support for old 5.x powershell #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 2 commits into from
Oct 27, 2025
Merged

do not enable OSC 7 support for old 5.x powershell #2485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21faa99
do not enable OSC 7 support for old 5.x powershell
sawka Oct 27, 2025
5a68dfe
fix a bug related to #2481 (not returning an error from failure to de…
sawka Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/remote/conncontroller/conncontroller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,7 @@ func (conn *SSHConn) InstallWsh(ctx context.Context, osArchStr string) error {
}
if err != nil {
conn.Infof(ctx, "ERROR detecting client platform: %v\n", err)
return fmt.Errorf("error detecting client platform: %w", err)
}
conn.Infof(ctx, "detected remote platform os:%s arch:%s\n", clientOs, clientArch)
err = remote.CpWshToRemote(ctx, client, clientOs, clientArch)
Expand Down
4 changes: 4 additions & 0 deletions pkg/util/shellutil/shellintegration/pwsh_wavepwsh.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ Remove-Item Env:WAVETERM_SWAPTOKEN
# Load Wave completions
wsh completion powershell | Out-String | Invoke-Expression

if ($PSVersionTable.PSVersion.Major -lt 7) {
return # skip OSC setup entirely
}

$Global:_WAVETERM_SI_FIRSTPROMPT = $true

# shell integration
Expand Down
Loading