Continue PR #7342: mobile signature placement flow by vitormattos · Pull Request #7408 · LibreSign/libresign

vitormattos · 2026-04-04T18:58:47Z

This PR continues the work from #7342 while preserving the original commit history from the abandoned branch.

What was done in this continuation:

Added a follow-up commit to fix TypeScript typing in src/tests/components/PdfEditor/PdfEditor.spec.ts for runtime-only mock members used by mobile placement tests.
Revalidated frontend checks locally for the impacted scope.

Validation run:

npm run ts:check
npm run test -- src/tests/components/PdfEditor/PdfEditor.spec.ts src/tests/components/Request/VisibleElements.spec.ts src/tests/components/RightSidebar/RequestSignatureTab.spec.ts src/tests/store/files.spec.ts

Notes:

Original PR Fix mobile signature placement flow, save visibility, and coordinate serialization #7342 points to a fork branch (Phillipxh:fix/mobile-signature-placement), so it could not be updated directly from this repository.

Signed-off-by: Phillip <phillipxh@gmail.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

- allow self worker-src on authenticated and public sign pages - normalize mailpit sign links to app-relative paths - add regression coverage for sign link extraction and sign-page CSP - configure native signing without TSA in the affected public-sign E2E flows - stabilize unauthenticated sign flows by clearing browser cookies before opening public links Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Updates to v1.2.0 which includes: - first-class pdf-elements:adding-ended event for interactive placement - event payload types (placed/cancelled) exported from package API - full test coverage for both event flows This aligns LibreSign to use the new stable event contract from pdf-elements, complementing the mobile signature placement flow refactorings in this PR. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

The PdfEditor component was still using setTimeout-based polling to detect when pdf-elements placement completed. With pdf-elements v1.2.0, this event is now exposed directly via 'pdf-elements:adding-ended' event with a complete event contract including the placement reason ('placed' or 'cancelled'). Changes: - Remove pendingAddedObjectCount and pendingAddCheckTimer state - Remove polling functions: clearPendingAddCheck, finishPendingAddCheck, checkSignerAdded, scheduleSignerAddedCheck - Remove document event listener registration (mouseup, touchend, keyup) - Add handleAddingEnded(event: Event) to relay pdf-elements:adding-ended directly to pdf-editor:adding-ended with the reason payload - Update emit type definition to include payload with reason field This completes the v1.2.0 migration from polling-based to event-driven completion detection. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Replace obsolete polling-based tests with new tests for the event relay pattern: - Remove: 'schedules a deferred completion check after a placement interaction' - Remove: 'emits adding-ended when object count increases after adding mode starts' - Remove: 'emits adding-ended when adding mode finishes without object delta' - Remove: 'keeps waiting while adding mode is active and count has not changed' - Remove: 'ignores completion checks when no add session is pending' - Remove: 'RULE: document listener lifecycle' test suite Add: 'RULE: pdf-elements event relay' test suite with: - 'relays pdf-elements:adding-ended event to pdf-editor:adding-ended' - 'relays cancelled event with reason' Update type definition PdfEditorVm: - Remove: checkSignerAdded, scheduleSignerAddedCheck - Add: handleAddingEnded(event: Event) All 60 PdfEditor tests now pass with event-driven model. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos · 2026-04-05T21:48:28Z

/backport to stable33

vitormattos · 2026-04-05T21:48:31Z

/backport to stable32

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Phillipxh and others added 5 commits March 30, 2026 22:05

fix(mobile): fix signature placement and coordinate serialization

9dbd66f

Signed-off-by: Phillip <phillipxh@gmail.com>

fix(mobile): harden touch placement and pdf-elements runtime behavior

2a18478

Signed-off-by: Phillip <phillipxh@gmail.com>

test(mobile): increase coverage for signature placement flows

64bfae6

Signed-off-by: Phillip <phillipxh@gmail.com>

fix(mobile): restore sign flow fallback for self-signer requests

46b1265

Signed-off-by: Phillip <phillipxh@gmail.com>

test: fix PdfEditor spec runtime mock typing

64c1367

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

github-project-automation bot added this to Roadmap Apr 4, 2026

github-project-automation bot moved this to 0. Needs triage in Roadmap Apr 4, 2026

vitormattos added 18 commits April 4, 2026 16:04

chore(deps): bump pdf-elements to 1.1.4

55fb2c6

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): refresh lockfile for pdf-elements

369182b

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-editor): remove touchend workaround internals

c8cfee7

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-editor): decouple model from pdf-elements type export

6404102

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(pdf-worker): import worker setup from exported asyncReader path

16c2c28

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(pdf-editor): drop workaround-specific touchend specs

5af2630

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(vite): remove pdf-elements runtime patch plugin

f3f06e6

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): bump pdf-elements to 1.1.5

d28214d

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): refresh lockfile for pdf-elements 1.1.5

e974e8f

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-editor): use pdf-elements exported object type

ca7e19c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-worker): restore root setWorkerPath import

cdca3a3

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(sign-route): avoid stale sign_request_uuid fallback

824db70

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(sign-route): cover stale state UUID regression

cb8c40a

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(pdf-editor): use theme tokens for action buttons

6711341

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(playwright): normalize sign links to relative app paths

c6be91e

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(playwright): simplify sign-link extraction to relative path

006e9fa

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Merge origin/main into pr-7342: resolve mailpit sign-link conflict

66c1b4e

vitormattos force-pushed the fix/mobile-signature-placement branch from 70477b3 to 197aa75 Compare April 4, 2026 22:15

vitormattos added 4 commits April 5, 2026 00:01

fix: alias pdf-elements to source in vite

2325014

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: align pdf-elements alias in vitest

452abc5

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: set pdf worker path synchronously

6523a77

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: initialize pdf worker before editor mount

933d326

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos added 12 commits April 5, 2026 00:44

test: mock package worker warmup in visible elements

75cf06c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: mock package worker warmup in request tab

fec5553

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: depend on pdf-elements 1.1.6

0006539

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: refresh frontend lockfile

1699055

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor: simplify pdf editor add completion flow

cc97412

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: handle pdf editor add completion event

a6db2b1

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover pdf editor add completion flow

b2c70db

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: update visible elements add completion event

aca0b9c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor: remove redundant PdfEditor lifecycle hooks

44bc430

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

backportbot-libresign bot added the backport-request label Apr 5, 2026

vitormattos added 9 commits April 5, 2026 18:52

fix: stabilize pdf editor action button colors in dark themes

57c01c8

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: strengthen toolbar color override selectors

090b52d

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: target pdf-elements scoped toolbar selector

94956bf

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: correct toolbar override selector nesting

4fcafaf

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

style: align pdf action toolbar with Nextcloud button aesthetics

5cffaa6

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat: consume pdf-elements action styling hooks

2ef3e06

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: bump pdf-elements dependency to 1.2.1

5f9409e

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: refresh lockfile for pdf-elements 1.2.1

73c9e00

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: hide sign action while positioning signer

6d480e5

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos merged commit 63ed061 into main Apr 5, 2026
77 checks passed

vitormattos deleted the fix/mobile-signature-placement branch April 5, 2026 23:20

github-project-automation bot moved this from 0. Needs triage to 4. to release in Roadmap Apr 5, 2026

This was referenced Apr 5, 2026

[stable32] Continue PR #7342: mobile signature placement flow #7415

Merged

[stable33] Continue PR #7342: mobile signature placement flow #7416

Merged

backportbot-libresign bot removed the backport-request label Apr 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Continue PR #7342: mobile signature placement flow#7408

Continue PR #7342: mobile signature placement flow#7408
vitormattos merged 69 commits intomainfrom
fix/mobile-signature-placement

vitormattos commented Apr 4, 2026 •

edited

Loading

Uh oh!

vitormattos commented Apr 5, 2026

Uh oh!

vitormattos commented Apr 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

vitormattos commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vitormattos commented Apr 5, 2026

Uh oh!

vitormattos commented Apr 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vitormattos commented Apr 4, 2026 •

edited

Loading