Refactor parse_header to return structured type and update to Rust 2024#11
Merged
Conversation
Member
Author
This was referenced Mar 11, 2026
Merged
antoniobg
approved these changes
Mar 11, 2026
bisho
force-pushed
the
03-10-upgrade_rust_stable_1.94
branch
from
d0a729c to
5b2899b
Compare
bisho
force-pushed
the
03-10-upgrade_to_pyo3_0.28.2
branch
from
a3ee3f3 to
3c19e11
Compare
This was referenced Mar 13, 2026
bisho
changed the base branch from
03-10-upgrade_to_pyo3_0.28.2
to
graphite-base/11
bisho
force-pushed
the
03-10-upgrade_rust_stable_1.94
branch
from
5b2899b to
94778c0
Compare
bisho
changed the base branch from
graphite-base/11
to
03-10-optimizations_and_improvements
bisho
changed the base branch from
03-10-optimizations_and_improvements
to
graphite-base/11
bisho
force-pushed
the
03-10-upgrade_rust_stable_1.94
branch
from
94778c0 to
3524694
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Description
This pull request refactors the memcache meta-protocol response header parsing functionality to improve code organization and maintainability. The changes introduce a structured approach to handling parsed header data and update the codebase to use Rust 2024 edition features.
Changes introduced
ParsedHeadertype containingend_pos,response_type,size, andflagsfieldsimpl_parse_headerfunction to use pattern matching with guard clauses and return structured dataDebugtrait derivation toRequestFlagsandResponseFlagsstructsfrom_py_objectforResponseFlagsPyClass and addedgil_used = falseto the PyModuletoo_many_argumentsandtype_complexitylints where appropriate