multi-get#16
Open
bisho wants to merge 1 commit into
Open
Conversation
This was referenced Mar 17, 2026
Merged
Member
Author
This was referenced Mar 17, 2026
|
@claude review this pr |
9f5a863 to
f9ac819
Compare
f714a41 to
b6c831e
Compare
c944e91 to
f66d7e5
Compare
b6c831e to
09802be
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds batch meta-get support to the MemcacheSocket implementation via a new meta_multiget method, enabling multiple mg commands to be issued and parsed within a single Rust call (with GIL released during socket I/O).
Changes:
- Added
MemcacheSocket.meta_multigetin Rust to pipeline multiplemgrequests and collect responses in input order. - Added a new Python test suite for
meta_multiget, including ordering, buffering, mixed hit/miss, and NOOP-drain scenarios. - Updated the
.pyitype stubs and documentation to exposemeta_multiget.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/memcache_socket.rs |
Implements meta_multiget with batched send + tight response loop under py.detach. |
tests/test_memcache_socket.py |
Adds batch-oriented tests for meta_multiget covering edge cases and socket state interactions. |
meta_memcache_socket.pyi |
Adds the meta_multiget stub and docstring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
09802be to
c5237c1
Compare
c5237c1 to
e46fe95
Compare
b4355f6 to
f582779
Compare
e46fe95 to
3cc05e3
Compare
ffe2649 to
5ef1f07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation / Description
This pull request adds batch operation support to the memcache socket implementation by introducing a
meta_multigetmethod that can efficiently retrieve multiple keys in a single operation.Changes introduced
meta_multigetmethod toMemcacheSocketclass that accepts a list of keys and optional request flagsget_valuemethod from the Rust implementationmeta_multigetmethod signature and documentation