feat(website): add copy and download buttons for sequences on details…#5880
feat(website): add copy and download buttons for sequences on details…#5880theosanderson merged 9 commits intomainfrom
Conversation
|
This PR resolves #5879 (Copy button and download button on sequences at bottom of details page) |
… page Add SequenceActionButtons component that provides: - Copy button to copy the sequence in FASTA format to clipboard with "Copied!" feedback - Download button to download the sequence as a .fasta file The buttons are displayed at the bottom of the sequence viewer on the sequence details page, using hydration-safe Button component to prevent flaky Playwright tests.
Move the copy and download buttons from the bottom of the sequence viewer to the top right corner, just below the tabs. Use absolute positioning to keep them out of the content flow.
…ion buttons Improves visibility of copy/download buttons overlaying the sequence text. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ab16053 to
22cc39f
Compare
Add data-testid to metadata download dropdown and use it in the integration test instead of getByText, avoiding collision with the new sequence download button. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
b6e050c to
2df9b34
Compare
|
Claude finished @theosanderson's task in 1m 23s —— View job Code Review Complete ✓
SummaryThis PR successfully adds copy and download functionality for sequences on the details page. The implementation is generally solid and follows the project's guidelines for preventing flaky Playwright tests by using the hydration-safe Strengths:
Issues Found:
Testing:
Documentation: Overall, this is a good implementation that needs a few refinements around error handling and edge cases before merging. |
Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
anna-parker
left a comment
There was a problem hiding this comment.
awesome! I tested it out a bit and the code looks good!
Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
#5880) … page Add SequenceActionButtons component that provides: - Copy button to copy the sequence in FASTA format to clipboard with "Copied!" feedback - Download button to download the sequence as a .fasta file The buttons are displayed at the bottom of the sequence viewer on the sequence details page, using hydration-safe Button component to prevent flaky Playwright tests. <img width="1343" height="432" alt="image" src="https://github.com/user-attachments/assets/553184af-aa19-460f-9258-f2ad8c8ebfb7" /> 🚀 Preview: Add `preview` label to enable --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Happy <yesreply@happy.engineering>
… page
Add SequenceActionButtons component that provides:
The buttons are displayed at the bottom of the sequence viewer on the sequence details page, using hydration-safe Button component to prevent flaky Playwright tests.
🚀 Preview: Add
previewlabel to enable