feat(ingest): Add host field for INSDC sequences during ingest#6534
Draft
maverbiest wants to merge 7 commits into
Draft
feat(ingest): Add host field for INSDC sequences during ingest#6534maverbiest wants to merge 7 commits into
maverbiest wants to merge 7 commits into
Conversation
Contributor
|
@maverbiest I would do this in three steps:
|
Contributor
Author
|
@anna-parker okay cool, thanks! I will get rid of the DB migration then and we can run it as a surgery. Regarding you point 1., could you clarify what you mean by 'modify the hash'? I thought the aim was to ensure the hash doesn't change so we don't trigger revisions? What I'm currently doing on this branch is collapsing the taxon id and scientific name fields into a single |
Contributor
yes I was unclear, I meant to modify the code for the hash calculation so that it doesnt change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #6533 #6295
Screenshot
PR Checklist
🚀 Preview: Add
previewlabel to enable