chore: fix driver test suite

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

• fix(envoy-client): add tls #4595 : 2 dependent PRs (#4597 , #4599 )
• chore: fix driver test suite #4591 👈 (View in Graphite)
• chore: tunnel auth #4588
• chore: remove udb as a dependency of envoy-client #4587
• chore: revert actor v2 hack #4586
• fix: fix pool metadata protocol version refresh, rivetkit native ws #4585
• feat: US-001 - Define SqliteKv trait in rivetkit-sqlite-native #4584
• feat(rust/engine-runner): minimal rust engine runner #4289
• chore: delete kv channel #4583
• feat(engine): rust runner #4582
• chore: remove non-engine drivers #4574 : 1 other dependent PR (#4581 )
• feat: dynamic actors #4397
• fix: driver test suite & sqlite reliability #4559
• fix: remove serverless token #4572
• fix: misc token fixes #4569
• fix(pb): clean up actor stop decision handling #4566
• fix(envoy): use global instance, add signal handlers #4565
• chore: misc fixes, add pb snapshot test #4561
• fix(cache): make in memory cache global #4560
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: chore: fix driver test suite

This PR refactors the driver test suite and includes runtime fixes in the envoy client, native SQLite database bindings, and the dynamic isolate runtime.

---

Bugs / Correctness Issues

1. std::sync::Mutex for JsNativeDatabase needs a justifying comment

File: rivetkit-typescript/packages/rivetkit-native/src/database.rs

CLAUDE.md prohibits Mutex for shared containers. The lock is never held across an .await (only acquired inside spawn_blocking), so std::sync::Mutex is acceptable here. Without a comment explaining this, a future reader will flag it as a policy violation.

2. as_ptr() silently returns null when database is closed

File: rivetkit-typescript/packages/rivetkit-native/src/database.rs

as_ptr() uses .unwrap_or(ptr::null_mut()), silently returning null if the database is closed or mutex is poisoned. Any caller passing this pointer to raw SQLite C functions without a null check will trigger undefined behavior. Either remove as_ptr() from the public surface or document that callers must null-check the return value.

3. EMPTY_KEY constant reused as join separator

File: engine/packages/guard/src/routing/pegboard_gateway/resolve_actor_query.rs

EMPTY_KEY is named for the empty-key sentinel but is reused as the join separator via escaped_parts.join(EMPTY_KEY). The naming is misleading. Consider renaming to KEY_SEPARATOR for the join, keeping EMPTY_KEY only for the early-return path.

4. bigint truncation in toNativeBinding

File: rivetkit-typescript/packages/rivetkit-native/wrapper.js

Number(bigint) loses precision for values outside Number.MAX_SAFE_INTEGER (2^53 - 1). SQLite INTEGER supports 64-bit signed integers and the Rust side accepts i64, so this silently truncates large values. Either throw for out-of-safe-range values or preserve full 64-bit precision across the boundary.

5. normalizeBindings throws on object bindings with positional ? params

File: rivetkit-typescript/packages/rivetkit-native/wrapper.js

When a caller passes a plain object as the binding but the SQL uses positional ? placeholders (valid SQLite), normalizeBindings throws "native sqlite object bindings require named placeholders". The check should fall through to positional binding when the SQL has no named params.

---

Code Quality Issues

6. execute_statement silently discards rows from RETURNING clauses

File: rivetkit-typescript/packages/rivetkit-native/src/database.rs

execute_statement steps through rows but discards all SQLITE_ROW results, silently discarding results from INSERT ... RETURNING. The JS execute wrapper guards this in practice, but a comment explaining the limitation would prevent future misuse if execute_statement is called directly.

7. Post-dispose pool re-creation risk in loadSqliteVfsPool

File: rivetkit-typescript/packages/rivetkit/dynamic-isolate-runtime/src/index.cts

The module-level sqliteVfsPoolPromise singleton is reset to undefined in dynamicDisposeEnvelope. If loadSqliteVfsPool is called after disposal, a new pool will be created post-dispose. Consider guarding with a disposed flag that permanently blocks re-initialization.

---

Convention Violations

8. console.error usage in wrapper.js

Several error paths use console.error for runtime errors. These are pre-existing but the PR converts these callbacks to async functions. CLAUDE.md requires structured logging rather than console.error for observable runtime errors.

---

Minor / Nits

• sandboxImageReady singleton reset-on-failure (sandbox.ts): Correctly resets to undefined in the catch block. Good pattern.
• onOpen retroactive fire (actor-conn.ts): The queueMicrotask pattern for late subscribers is correct. The openHandlers guard is a nice safety touch.
• schedule-sleep.ts: Removing the setTimeout wrapper changes observable timing. Confirm the test suite validates this does not cause a premature sleep response race.
• .agent/notes/driver-engine-static-test-order.md: Correct placement per CLAUDE.md.

---

Summary

Priority	File	Issue
High	database.rs	as_ptr() can return null - document or remove from public API
High	wrapper.js	bigint truncation in toNativeBinding loses precision silently
Medium	resolve_actor_query.rs	Rename EMPTY_KEY used as join separator
Medium	database.rs	Add comment justifying std::sync::Mutex in spawn_blocking context
Medium	wrapper.js	normalizeBindings throws on object bindings with positional params
Low	index.cts	Guard loadSqliteVfsPool against post-dispose re-creation

[MasterPtato]

Merge activity

• Apr 13, 12:21 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Apr 13, 12:22 AM UTC: @MasterPtato merged this pull request with Graphite.