chore(rivetkit): remove wasm sqlite runtime

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(engine): publish engine bases in ci #4649 : 3 dependent PRs (#4650 , #4652 , #4654 )
• chore: lockfile lefthook #4647
• fix(rivetkit): surface native sqlite kv errors to callers #4645
• fix(rivetkit): prevent sleep races during disconnect and db work #4644
• fix(rivetkit): isolate engine envoys and propagate startup failures #4643
• test(rivetkit): remove wasm sqlite-only fixtures and coverage #4642
• chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring #4641
• chore(rivetkit): remove wasm sqlite runtime #4614 👈 (View in Graphite)
• fix(sqlite-native): restore native startup kv preload #4639
• fix(sqlite-native): delete metadata before chunk range #4638
• fix(sqlite-native): keep truncate cache coherent #4637
• fix(sqlite-vfs): use delete range for truncate cleanup #4636
• fix(sqlite-native): restore kv error hook #4635
• perf(sqlite-native): avoid cloning cached read chunks #4634
• perf(sqlite-native): gate kv operation labels #4633
• perf(sqlite-native): reuse read cache for partial writes #4632
• perf(sqlite-native): remove delete file existence probe #4631
• fix(sqlite-native): gate native read cache behind env var #4630
• fix(pegboard): isolate runner config dc lookup failures #4625 : 1 other dependent PR (#4626 )
• docs(pegboard): note runner config upsert split write risk #4624
• fix(pegboard): unpack global runner config keys correctly #4623
• fix(pegboard-gateway): enforce tunnel message state #4622
• fix(pegboard-runner): clear terminal tunnel routes #4621
• fix(pegboard): skip protocol version keys in runner pool backfill #4620
• fix(pegboard): create missing normal runner configs #4619
• fix(epoxy): reuse cached optimistic value #4618
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review: chore(rivetkit): remove wasm sqlite runtime

Overview

This PR removes the WASM SQLite runtime (@rivetkit/sqlite-wasm) and the deprecated NativeSqliteConfig / native-sqlite.ts transport-based approach in favor of a cleaner NativeDatabaseProvider abstraction that opens databases from a live runtime handle (the native envoy). It's a significant simplification: ~1,700 lines deleted, ~490 added, and several layers of indirection removed.

---

Positive Changes

• Cleaner abstraction. Replacing ISqliteVfs + NativeSqliteConfig + openActorDatabase with a single NativeDatabaseProvider / SqliteDatabase interface is the right direction. Less surface area, easier to reason about.
• Dead code removed. native-sqlite.ts, native-adapter.ts, open-database.ts, sqlite-pool.ts, and SqliteVfsPoolManager are cleanly deleted. The @rivetkit/sqlite-wasm dependency is also dropped from package.json.
• Duplicate binding normalization eliminated. Both wrapper.js and native-adapter.ts had their own copies of normalizeBindings/toNativeBinding. The new native-database.ts consolidates this into one place.
• Isolate bridge improved. DB operations are now explicit named bridge keys (dbExec, dbQuery, dbRun, dbClose) rather than going through the VFS pool. This is more debuggable and does not carry WASM lifecycle overhead.
• Rust comment cleanup. Removing Matches <TypeScript file> cross-references from kv.rs and vfs.rs is correct since the WASM counterpart is gone; no stale pointers.

---

Issues and Suggestions

1. Silent swallowed errors during shutdown (high)

In dynamic-isolate-runtime/src/index.cts, the shutdown loop swallows all close() errors with // noop. The same pattern appears in isolate-runtime.ts. Per the project style (and how WebSocket session teardown is handled in those same files), errors should be logged at warn level instead of silently ignored, so they appear in diagnostics when actors fail to clean up cleanly.

2. Modifying Map while iterating it (medium)

In index.cts, the shutdown loop calls database.close(), which internally calls nativeDatabaseCache.delete(actorId) (via createNativeDatabaseBridge's close() implementation), and then the loop also calls nativeDatabaseCache.delete(actorId) again. The double-delete is benign but confusing. Mutating a Map during .entries() iteration is safe in JS but can be surprising. Consider snapshotting and clearing first:

const entries = [...nativeDatabaseCache.entries()];
nativeDatabaseCache.clear();
for (const [, database] of entries) { ... }

3. Removed user-facing error context for native database failures (medium)

The old db/mod.ts wrapped errors with a descriptive message when the underlying KV/VFS layer became unavailable:

"Database query failed because the underlying storage is no longer available (...)."

This hint is now gone. When the envoy disconnects mid-query, users will see a raw error from the native layer with no guidance to check c.abortSignal. Consider retaining this at the RawAccess.execute level.

4. toNativeBindings silently changes behavior for named-param objects without placeholders (low)

In the new native-database.ts, when a named-param object is passed but the SQL has no named placeholders, the function falls through to Object.values(params).map(...) rather than throwing. The old code in both native-adapter.ts and wrapper.js threw an explicit error in this case. This is a subtle behavior change that could mask binding mismatches.

5. NativeDatabaseProvider.open is a breaking interface change (low, informational)

The old signature accepted optional preloaded entries; the new one drops them entirely and also changes the return type from Promise<RawAccess> to Promise<SqliteDatabase>. Any external driver implementing this interface will need updating. Worth noting in the PR description.

6. CLAUDE.md VFS parity requirement is now stale (low)

CLAUDE.md still says "The native Rust VFS and the WASM TypeScript VFS must match 1:1" and lists sqlite-wasm/src/vfs.ts as a relevant file. Since that package is being removed, this section should be revised so it does not mislead future contributors.

7. Test checklist is unchecked (low)

Given the scale of this change (all db paths route through the native provider), a note on which driver tests cover the new path, and whether any fixtures that used createSqliteVfs were updated, would help reviewers gain confidence.

---

Summary

Well-scoped cleanup that removes a significant amount of legacy indirection. The core design is sound. The main actionable items are: log shutdown close-errors instead of swallowing them, snapshot the Map before iterating during shutdown, and restore user-facing context in native database error paths. CLAUDE.md should also be updated to remove the now-inapplicable WASM VFS parity requirement.

[github-actions]

Preview packages published to npm

Install with:

npm install rivetkit@pr-4614

All packages published as 0.0.0-pr.4614.822b57f with tag pr-4614.

Engine binary is shipped via @rivetkit/engine-cli (platforms: linux-x64-musl, linux-arm64-musl, darwin-x64, darwin-arm64). rivetkit resolves it automatically at runtime.

Docker images:

docker pull rivetdev/engine:slim-822b57f
docker pull rivetdev/engine:full-822b57f

Individual packages

npm install rivetkit@pr-4614
npm install @rivetkit/react@pr-4614
npm install @rivetkit/rivetkit-native@pr-4614
npm install @rivetkit/workflow-engine@pr-4614