Skip to content

chore: lockfile lefthook#4647

Open
NathanFlurry wants to merge 1 commit intofix/surface-native-sqlite-kv-errorsfrom
04-13-chore_lockfile_lefthook
Open

chore: lockfile lefthook#4647
NathanFlurry wants to merge 1 commit intofix/surface-native-sqlite-kv-errorsfrom
04-13-chore_lockfile_lefthook

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 13, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude bot commented Apr 13, 2026

PR Review: chore: lockfile lefthook

What This PR Does

Adds lockfile validation pre-commit hooks to lefthook.yml, fixes YAML indentation, removes the rivetkit-sqlite-native workspace dependency from Cargo.toml, updates pnpm-lock.yaml (switches @rivetkit/engine-api-full from an external preview URL to workspace:*, registers new sqlite-vfs package), and fixes method-chain indentation in database.rs.


Issues Found

High Severity

Cargo.toml - Removing rivetkit-sqlite-native workspace dependency will break the build

The PR removes the workspace declaration for rivetkit-sqlite-native, but rivetkit-typescript/packages/rivetkit-native/Cargo.toml still declares rivetkit-sqlite-native.workspace = true. Removing the workspace entry while the consumer crate still references it via .workspace = true will cause a cargo build failure. Either keep the workspace entry, or update rivetkit-native/Cargo.toml to use a direct path reference instead.


Low Severity

lefthook.yml - pnpm-lock hook runs on every commit with no file filter

pnpm install --frozen-lockfile runs on every commit regardless of whether any package.json or lockfile changed. This will add unnecessary delay to commits that only touch Rust, docs, or other non-Node files. Adding a glob field would restrict the hook to commits that actually modify package manifests. The cargo-lock hook (cargo metadata --no-deps) is fast enough that the missing filter is not a concern there.


Looks Good

  • pnpm-lock.yaml - Switching @rivetkit/engine-api-full from the external pkg.pr.new preview URL to workspace:* is correct and consistent with the root resolutions entry. The new sqlite-vfs importer section looks mechanically correct.
  • database.rs - The method-chain indentation fix is correct.
  • lefthook.yml comment fix - Converting the hard-tab indentation in the commented block to spaces is the right fix for valid YAML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant