fix(pegboard): create missing normal runner configs

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

• fix(pegboard): isolate runner config dc lookup failures #4625 : 2 dependent PRs (#4626 , #4630 )
• docs(pegboard): note runner config upsert split write risk #4624
• fix(pegboard): unpack global runner config keys correctly #4623
• fix(pegboard-gateway): enforce tunnel message state #4622
• fix(pegboard-runner): clear terminal tunnel routes #4621
• fix(pegboard): skip protocol version keys in runner pool backfill #4620
• fix(pegboard): create missing normal runner configs #4619 👈 (View in Graphite)
• fix(epoxy): reuse cached optimistic value #4618
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: fix(pegboard): create missing normal runner configs

Summary

This is a minimal, correct one-character logic inversion bug fix. The function pegboard_runner_config_ensure_normal_if_missing is supposed to create a default "normal" runner config if one does not already exist. The original code had the condition inverted:

// Before (bug): creates config only when one already exists
if !pool_res.is_empty() { ... }

// After (fix): creates config only when none exists
if pool_res.is_empty() { ... }

The broken condition caused the upsert to fire when a config already existed and silently skip creation when one was missing — the exact inverse of the intended semantics described in the function's doc comment.

---

Feedback

Correctness — Fix is correct. The get call returns a Vec<RunnerConfig> filtered to found entries, so an empty result means the config is absent. The corrected is_empty() guard now matches the documented intent.

Pre-existing doc comment nit (not introduced by this PR): the doc comment fragment Returns true when the config was created is stale since the function returns Result<()>, not Result<bool>. Worth cleaning up.

Test coverage — No tests are added. Given the function is used as a workflow activity in runner2.rs, a regression test confirming that configs are created when absent (and not overwritten when present) would prevent this class of inversion bug from re-appearing.

---

Assessment

Correct, minimal, and safe. No style/convention violations, no security concerns, no performance impact. The only suggestions are a pre-existing stale doc comment and the absence of a regression test.

[github-actions]

Preview packages published to npm

Install with:

npm install rivetkit@pr-4619

All packages published as 0.0.0-pr.4619.7b60796 with tag pr-4619.

Engine binary is shipped via @rivetkit/engine-cli on linux-x64-musl, linux-arm64-musl, darwin-x64, and darwin-arm64. Windows users should use the release installer or set RIVET_ENGINE_BINARY.

Docker images:

docker pull rivetdev/engine:slim-7b60796
docker pull rivetdev/engine:full-7b60796

Individual packages

npm install rivetkit@pr-4619
npm install @rivetkit/react@pr-4619
npm install @rivetkit/rivetkit-native@pr-4619
npm install @rivetkit/sqlite-wasm@pr-4619
npm install @rivetkit/workflow-engine@pr-4619

[MasterPtato]

Merge activity

• Apr 13, 8:40 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Apr 13, 8:42 PM UTC: Graphite rebased this pull request as part of a merge.
• Apr 13, 8:42 PM UTC: @MasterPtato merged this pull request with Graphite.