feat(website): Add tab on revise page pointing to per-sequence revise button#6504
feat(website): Add tab on revise page pointing to per-sequence revise button#6504theosanderson-agent wants to merge 5 commits into
Conversation
… button Adds a second tab to the revise page that explains how to revise an individual sequence entry: users can open the sequence's details page and click "Revise this sequence" under "Sequence management". The tab also links to the user's "My sequences" page so they can browse to find the entry they want to revise. The existing bulk-upload behaviour is unchanged and lives under the first tab. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@theosanderson-agent make the text of the tab "Revising individual sequences" |
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Done — updated the form tab on the revise page to read "Revising individual sequences" in 0ca2a13. |
theosanderson
added
preview
|
@theosanderson-agent change 'form' for 'individual' |
|
also @theosanderson-agent rather than "My sequences", it should be "Released sequences". |
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Renamed the link text and button from "My sequences"/"Browse my sequences" to "Released sequences"/"Browse released sequences" in 4431a0c. |
Renames the InputMode literal from 'form' to 'individual' across the submission UI. The pair 'individual' | 'bulk' more accurately describes the two paths (one-at-a-time vs. file upload), especially now that the revise variant is an info page rather than a form. Also updates the URL query parameter (?inputMode=individual). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Renamed the |
|
@theosanderson-agent ah if we would have to change it across the UI revert. I meant just in this case |
…al'" This reverts commit e5166ba.
|
Reverted the |
|
Claude finished @theosanderson's task in 1m 44s —— View job Code Review
Clean, self-contained implementation. The overall approach is solid — the new Two minor notes left as inline comments:
No security, performance, or correctness issues found. No tests are strictly needed for the new component since it contains no logic — just static markup and route links. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| @@ -0,0 +1,53 @@ | |||
| import { type FC } from 'react'; | |||
|
|
|||
| import { InputModeTabs } from './DataUploadForm.tsx'; | |||
There was a problem hiding this comment.
Importing InputModeTabs from DataUploadForm.tsx couples this lightweight static component to a heavy form module (brings in all of DataUploadForm's dependencies like axios, react-query, etc.). Consider moving InputModeTabs to its own file (e.g. InputModeTabs.tsx) so both DataUploadForm and SingleSequenceReviseInfo can import it without this coupling.
| ) : ( | ||
| <FormOrUploadWrapper | ||
| inputMode='bulk' | ||
| setFileFactory={setFileFactory} | ||
| organism={organism} | ||
| action={action} | ||
| metadataTemplateFields={metadataTemplateFields} | ||
| submissionDataTypes={submissionDataTypes} | ||
| /> | ||
| <> | ||
| <h1 className='title'>Revise sequences</h1> | ||
| <InputModeTabs | ||
| action={action} |
There was a problem hiding this comment.
In the revise branch here, inputMode (the prop passed to DataUploadForm) is silently ignored — both InputModeTabs and FormOrUploadWrapper are hardcoded to 'bulk'. This is fine since RevisionForm already guards against calling DataUploadForm with inputMode='form', but it means the inputMode prop accepted by DataUploadForm is meaningless for the revise action. Worth noting, though not necessarily fixing since the routing logic is handled correctly in RevisionForm.
2 participants
Summary
Inspired by #6503 but just pointing users to the "canonical place" instead
🚀 Preview: https://revise-info-tab.loculus.org